Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose grammar object for customisation #103

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Expose grammar object for customisation #103

merged 2 commits into from
Nov 26, 2024

Conversation

reznikov
Copy link
Contributor

Hey!
This PR allows to mutate the grammar before parsing. This is useful when dealing with custom sdp attributes.

@reznikov
Copy link
Contributor Author

hey @clux,
would it be possible for you to review this PR, please?

clux
clux approved these changes Nov 26, 2024
View reviewed changes
Copy link
Owner

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Sorry missed it earlier. Elegant way of doing this imo.

@clux clux merged commit fa86976 into clux:master Nov 26, 2024
2 checks passed
clux added a commit that referenced this pull request Nov 26, 2024
@clux
prep a release
14709b7 
for #103

Signed-off-by: clux <[email protected]>
@clux
Copy link
Owner

clux commented Nov 26, 2024

it's in 2.15.0 now 😄

@reznikov
Copy link
Contributor Author

it's in 2.15.0 now 😄

thanks! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reznikov @clux